feat: improve notification read management - #13
Conversation
Improve the per-notification read affordance and page unread notifications in five-item windows.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d04d0d5404
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep the larger notification read target while reducing its idle contrast against the panel.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Center the notification page counter against its arrow controls.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Paginated notifications should expose page controls and bulk read, not the generic show-all button.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Keep bulk read visible while notification data refreshes and remove the misleading open-link indicator from read-toggle rows.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Keep notification bulk and open controls visually consistent with other section footers.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Use a transparent idle background for notification read controls to match other buttons.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Make the notification read target a full-height trailing strip with only a left divider.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Match upstream bulk-read control readiness behavior while retaining notification pagination.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Keep Mark all read visible until notifications are ready, and make the per-row read action a full-height attached strip. Also retain the matching bordered Open in GitHub control for assigned issues. Validation: - tests/panel-source-test.sh - tests/service-source-test.sh - tests/helper-test.sh - omarchy plugin validate . Assisted-by: Codex/GPT-5
Selecting the full-height read action now selects its parent row too, keeping hover feedback visually continuous. Validation: - tests/panel-source-test.sh - tests/service-source-test.sh - tests/helper-test.sh - omarchy plugin validate . Assisted-by: Codex/GPT-5
Optimistically clear notifications during bulk marking, restore them on failure, and retain the authoritative refresh after completion. Validation: - tests/service-source-test.sh - tests/panel-source-test.sh - tests/helper-test.sh - omarchy plugin validate . Assisted-by: Codex/GPT-5
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90062f9f35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Clear bulk-marked notifications in one model update and restore failed operations in their original order. Validation: - tests/service-source-test.sh - tests/panel-source-test.sh - tests/helper-test.sh - omarchy plugin validate . Assisted-by: Codex/GPT-5
|
Thanks @AnthonyPoschen, this is a great contribution! 🙏 I pulled the branch down and ran it locally — the paginated five-item windows, the full-height per-row read strip, and the always-visible (but gated) bulk action all work nicely, and the optimistic clear on "Mark all read" makes the panel feel much snappier. All test suites and I also confirmed the three Codex review findings (inert expansion control, per-ID bulk removal cost, reversed restore order) were all addressed in your follow-up commits. Merging — thanks again for taking #12 on! |
2 participants
Closes #12
Validation:
tests/panel-source-test.shtests/service-source-test.shtests/helper-test.shomarchy plugin validate .